Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to specify download folder #418

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Add option to specify download folder #418

merged 5 commits into from
Aug 16, 2023

Conversation

s-l-teichmann
Copy link
Contributor

Solves #398

JanHoefelmeyer
JanHoefelmeyer previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

@JanHoefelmeyer JanHoefelmeyer mentioned this pull request Aug 2, 2023
Closed
@bernhardreiter bernhardreiter linked an issue Aug 15, 2023 that may be closed by this pull request
Allow for all downloaded files to be stored within a singular folder #398
Closed
bernhardreiter
bernhardreiter previously approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@bernhardreiter bernhardreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough to go in.

The documentation for the option can be improved in a new PR to make clear that it is a folder relative to the DIR and to fix the minor spelling issue in are stored in folder name by the year.

@bernhardreiter bernhardreiter self-requested a review August 15, 2023 16:22
bernhardreiter
bernhardreiter approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@bernhardreiter bernhardreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JanHoefelmeyer
JanHoefelmeyer approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm & works

@bernhardreiter bernhardreiter merged commit 8c95795 into main Aug 16, 2023
2 checks passed
@bernhardreiter bernhardreiter deleted the download-folder branch August 16, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

@bernhardreiter bernhardreiter bernhardreiter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for all downloaded files to be stored within a singular folder
3 participants
@s-l-teichmann @bernhardreiter @JanHoefelmeyer