Dedup code a bit

gocsaf · Aug 23, 2023 · 4dfa2dd · 4dfa2dd
1 parent 1281543
commit 4dfa2dd
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/cmd/csaf_checker/processor.go b/cmd/csaf_checker/processor.go
@@ -1131,18 +1131,19 @@ func (p *processor) checkMissing(string) error {
 			}
 		}
 		// List error in all appropriate categories
-		if mistake&rolieMask != 0 {
-			p.badROLIEFeed.error("%s %s", f, strings.Join(where, ", "))
-		}
-		if mistake&indexMask != 0 {
-			p.badIndices.error("%s %s", f, strings.Join(where, ", "))
-		}
-		if mistake&changesMask != 0 {
-			p.badChanges.error("%s %s", f, strings.Join(where, ", "))
+		if mistake&(rolieMask|indexMask|changesMask|listingMask) == 0 {
+			continue
 		}
-		if mistake&listingMask != 0 {
-			p.badDirListings.error("%s %s", f, strings.Join(where, ", "))
+		joined := strings.Join(where, ", ")
+		report := func(mask whereType, msgs *topicMessages) {
+			if mistake&mask != 0 {
+				msgs.error("%s %s", f, joined)
+			}
 		}
+		report(rolieMask, &p.badROLIEFeed)
+		report(indexMask, &p.badIndices)
+		report(changesMask, &p.badChanges)
+		report(listingMask, &p.badDirListings)
 	}
 	return nil
 }