test-pkg-cloud #21
Open
test-pkg-cloud #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmhu
reviewed
Sep 21, 2022
pkg/cloud/cloud_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestPriceConfig_GetConfig(t *testing.T) { |
There was a problem hiding this comment.
meanness test, suggest to remove it
Signed-off-by: jxs1211 <[email protected]>
jxs1211
force-pushed
the
test-pkg-cloud-2
branch
from
0f5341b
to
0e88371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jxs1211 [email protected]
Description
ut
Related Issues
N/A
New Behavior (screenshots if needed)
PS D:\shen\go\open_source\fadvisor\pkg\cloud> go test -v -cover
=== RUN TestDetectRegion
=== RUN TestDetectRegion/base
=== RUN TestDetectRegion/qcloud_with_no_node_labels
=== RUN TestDetectRegion/qcloud_with_node_labels
--- PASS: TestDetectRegion (0.00s)
--- PASS: TestDetectRegion/base (0.00s)
--- PASS: TestDetectRegion/qcloud_with_no_node_labels (0.00s)
--- PASS: TestDetectRegion/qcloud_with_node_labels (0.00s)
=== RUN TestDetectProvider
=== RUN TestDetectProvider/base
=== RUN TestDetectProvider/qcloud
--- PASS: TestDetectProvider (0.00s)
--- PASS: TestDetectProvider/base (0.00s)
--- PASS: TestDetectProvider/qcloud (0.00s)
=== RUN TestNewProviderConfig
=== RUN TestNewProviderConfig/base
--- PASS: TestNewProviderConfig (0.00s)
--- PASS: TestNewProviderConfig/base (0.00s)
=== RUN TestPriceConfig_GetConfig
=== RUN TestPriceConfig_GetConfig/base
--- PASS: TestPriceConfig_GetConfig (0.00s)
--- PASS: TestPriceConfig_GetConfig/base (0.00s)
PASS
coverage: 22.4% of statements
ok github.com/gocrane/fadvisor/pkg/cloud 1.394s
PS D:\shen\go\open_source\fadvisor\pkg\cloud>