Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure static agents are listening on accessible ports when health checks enabled #107

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Ensure static agents are listening on accessible ports when health checks enabled #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gocd/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
### 2.9.3
* Ensure agent is listening on correct interface when health check enabled (thanks to @chadlwilson and @12345ieee)
### 2.9.2
* Bump pre-installed plugins to latest patched versions (thanks to @chadlwilson)
### 2.9.1
Expand Down
2 changes: 1 addition & 1 deletion gocd/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
name: gocd
home: https://www.gocd.org/
version: 2.9.2
version: 2.9.3
appVersion: 24.3.0
description: GoCD is an open-source continuous delivery server to model and visualize complex workflows with ease.
icon: https://gocd.github.io/assets/images/go-icon-black-192x192.png
Expand Down
4 changes: 2 additions & 2 deletions gocd/templates/gocd-agent-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ spec:
- name: AGENT_AUTO_REGISTER_HOSTNAME
value: {{ .Values.agent.env.agentAutoRegisterHostname }}
{{- end }}
{{- if .Values.agent.env.goAgentJvmOpts }}
{{- if or .Values.agent.healthCheck.enabled .Values.agent.env.goAgentJvmOpts }}
- name: GOCD_AGENT_JVM_OPTS
value: {{ .Values.agent.env.goAgentJvmOpts }}
value: {{ if .Values.agent.healthCheck.enabled }}-Dgo.agent.status.api.bind.host=0.0.0.0{{ end }} {{ .Values.agent.env.goAgentJvmOpts }}
{{- end }}
{{- if .Values.agent.env.goAgentBootstrapperJvmArgs }}
- name: AGENT_BOOTSTRAPPER_JVM_ARGS
Expand Down