Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CIL to support Universal Character Names, char16_t, and char32_t (part of C99/C11) #604

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

michael-schwarz
Copy link
Member

This bumps the version of CIL to the one including goblint/cil#80.

This also requires some small changes, as CStr and CWStr now come with an encoding. We currently don't use the encoding anywhere.

@michael-schwarz michael-schwarz added c99 dependencies Pull requests that update a dependency file c11 labels Feb 19, 2022
Copy link
Member

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't use the encoding anywhere.

Would there even be anything to do with the encoding? Or would it only matter for some string analysis that we won't have any time soon?

@michael-schwarz
Copy link
Member Author

I don't really see what one would do with the encoding right now, but I guess it doesn't hurt to still have it in CIL, if we ever add such string analyses or discover that there are some stupid corner cases where soundness somehow depends on it.

@michael-schwarz michael-schwarz merged commit f365ae5 into master Feb 21, 2022
@michael-schwarz michael-schwarz deleted the cil_universial_character_names branch February 21, 2022 09:20
@sim642 sim642 added this to the v2.0.0 milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c11 c99 dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants