Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for md5-digest sasl auth. #43

Closed
wants to merge 1 commit into from
Closed

feat: add support for md5-digest sasl auth. #43

wants to merge 1 commit into from

Conversation

linsite
Copy link

@linsite linsite commented Nov 18, 2020

Hello, I'm working with go-zookeeper, but found that SASL was not supported yet, as this issue says. As this feature is so import to my work that I do a little work and test, I think it works. Would you please take some time to reivew it? If there are problems I will try to fix them. Thanks for you time!

@jeffbean

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #43 (28dff5b) into master (54f4812) will decrease coverage by 0.28%.
The diff coverage is 72.51%.

❗ Current head 28dff5b differs from pull request most recent head 1dd7138. Consider uploading reports for the commit 1dd7138 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   76.11%   75.83%   -0.29%     
==========================================
  Files           7        8       +1     
  Lines        1189     1295     +106     
==========================================
+ Hits          905      982      +77     
- Misses        195      214      +19     
- Partials       89       99      +10     
Impacted Files Coverage Δ
constants.go 75.00% <ø> (ø)
structs.go 80.08% <0.00%> (-0.68%) ⬇️
conn.go 71.63% <56.92%> (-1.52%) ⬇️
sasl.go 90.47% <90.47%> (ø)
util.go 93.75% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f4812...1dd7138. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant