fix(step): set step error for on_start failure using bad image (#527)

* working code * fix step in local * add comment --------- Co-authored-by: TimHuynh <[email protected]>
go-vela · Oct 27, 2023 · 6494030 · 6494030
1 parent bcdf8e4
commit 6494030
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/executor/linux/step.go b/executor/linux/step.go
@@ -152,6 +152,10 @@ func (c *client) ExecStep(ctx context.Context, ctn *pipeline.Container) error {
 	// run the runtime container
 	err = c.Runtime.RunContainer(ctx, ctn, c.pipeline)
 	if err != nil {
+		// set step status to error and step error
+		_step.SetStatus(constants.StatusError)
+		_step.SetError(err.Error())
+
 		return err
 	}
 

diff --git a/executor/local/step.go b/executor/local/step.go
@@ -83,6 +83,10 @@ func (c *client) ExecStep(ctx context.Context, ctn *pipeline.Container) error {
 	// run the runtime container
 	err = c.Runtime.RunContainer(ctx, ctn, c.pipeline)
 	if err != nil {
+		// set step status to error and step error
+		_step.SetStatus(constants.StatusError)
+		_step.SetError(err.Error())
+
 		return err
 	}
 

diff --git a/internal/step/snapshot.go b/internal/step/snapshot.go
@@ -16,8 +16,10 @@ import (
 // Snapshot creates a moment in time record of the
 // step and attempts to upload it to the server.
 func Snapshot(ctn *pipeline.Container, b *library.Build, c *vela.Client, l *logrus.Entry, r *library.Repo, s *library.Step) {
-	// check if the build is not in a canceled status
-	if !strings.EqualFold(s.GetStatus(), constants.StatusCanceled) {
+	// check if the build is not in a canceled status or error status
+	logrus.Debugf("Snapshot s: %s %s", s.GetName(), s.GetStatus())
+	if !strings.EqualFold(s.GetStatus(), constants.StatusCanceled) &&
+		!strings.EqualFold(s.GetStatus(), constants.StatusError) {
 		// check if the container is running in headless mode
 		if !ctn.Detach {
 			// update the step fields to indicate a success