Skip to content
reviewdog

refactor: remove types dependency #1926

Sign in to view logs

refactor: remove types dependency

refactor: remove types dependency #1926

Triggered via pull request October 22, 2024 14:27
@ecrupperecrupper
opened #610
refactor/nested-api/log-and-misc
Status Success
Total duration 2m 33s
Artifacts –

reviewdog.yml

on: pull_request
diff-review
2m 24s
diff-review
full-review
2m 23s
full-review
Fit to window
Zoom out
Zoom in

Annotations

20 errors
diff-review: runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
diff-review: runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
diff-review: cmd/vela-worker/exec.go#L29
cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
diff-review: internal/service/upload_test.go#L165
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: internal/service/snapshot_test.go#L137
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: mock/docker/service.go#L24
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: mock/docker/mock.go#L58
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: mock/docker/system.go#L24
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
full-review: runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
full-review: runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
full-review: cmd/vela-worker/exec.go#L29
cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
full-review: mock/docker/system.go#L24
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: mock/docker/system.go#L33
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: mock/docker/node.go#L22
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: internal/service/upload_test.go#L165
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: internal/service/snapshot_test.go#L137
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)