enhance(operate): check in loop more responsive to termination signal #1881
Triggered via pull request
September 18, 2024 16:06
ecrupper
Status
Success
Total duration
2m 47s
Artifacts
–
reviewdog.yml
on: pull_request
diff-review
2m 32s
full-review
2m 37s
Annotations
20 errors and 2 warnings
|
diff-review:
runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
diff-review:
runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
diff-review:
cmd/vela-worker/exec.go#L31
cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
|
|
diff-review:
mock/docker/volume.go#L30
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
mock/docker/volume.go#L72
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
mock/docker/volume.go#L109
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
full-review:
runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
full-review:
cmd/vela-worker/exec.go#L31
cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
|
|
full-review:
mock/docker/volume.go#L30
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
mock/docker/volume.go#L72
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
mock/docker/volume.go#L109
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|
|
full-review
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|