Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add slim version of git plugin #162

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

wass3rw3rk
Copy link
Member

@wass3rw3rk wass3rw3rk commented Sep 4, 2024

in order to keep the base git plugin as lightweight as possible, we are splitting the plugin into two versions: vela-git and vela-git-slim.

vela-git will contain additional "helper" packages. at this point, that is gh and git-lfs, but there is potential it might grow further.

the -slim variant will only contain git - the bare minimum needed for regular git operations required for most "clone" steps. this will also be the default plugin for the go-vela/server and go-vela/cli modules (additional PRs will follow).

here's an incremental breakdown of size differences:

image size
vela-git 30.3MB
vela-git + github-cli 82.9MB
vela-git + github-cli + git-lfs 90.2MB

when compressed, you are looking at roughly:

image size
vela-git-slim (new with this PR) 10.6MB
vela-git (includes github-cli + git-lfs) 29.4MB

@wass3rw3rk wass3rw3rk requested a review from a team as a code owner September 4, 2024 19:52
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.66%. Comparing base (612bfde) to head (c06cafc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   43.66%   43.66%           
=======================================
  Files           7        7           
  Lines         355      355           
=======================================
  Hits          155      155           
  Misses        186      186           
  Partials       14       14           

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3rw3rk wass3rw3rk merged commit 5e6f051 into main Sep 4, 2024
11 of 13 checks passed
@wass3rw3rk wass3rw3rk deleted the enhance/add-slim branch September 4, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants