Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial straw man implementation. I'm expecting to clean up source, testing, and commit messages before creating a final PR for merging. The goal for this draft PR of early work is merely to solicit feedback. Some bits remain awkward. The way the plugin is deciding whether to execute Build or Manifest commands is a total kludge, for instance.
Specific questions I'd appreciate feedback on:
--os-features
flags in a list manifest? The docs list it as an array of strings, but I'm not sure if a simple comma-separated list is what is expected. Perhaps I should provide multiple--os-features
arguments? I've just honestly not encountered it.vela-docker-manifest
plugin? I'm hesitant to do so, as the entire repository infrastructure is shared, but the current build/manifest dichotomy feels very awkward.This is an attempt to resolve go-vela/community#482