Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployments): updating ui to show new changes to database #753

Merged
merged 8 commits into from
Jan 15, 2024

Conversation

claire1618
Copy link
Contributor

@claire1618 claire1618 commented Jan 4, 2024

This story is attached to this PR: go-vela/server#1031

In switching over from pulling in deployments information from the SCM to pulling in from our own database, a few changes were made in the ui to allow this to happen.

As well, an ID column and builds column were added to the deployments table to better help users comprehend and use deployments.

@claire1618 claire1618 requested a review from a team as a code owner January 4, 2024 21:22
@wass3r wass3r changed the title Feat: updating ui to show new changes to deployments database feat(deployments): updating ui to show new changes to database Jan 5, 2024
KellyMerrick
KellyMerrick previously approved these changes Jan 10, 2024
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/elm/Pages/Deployments/View.elm Outdated Show resolved Hide resolved
src/elm/Pages/Deployments/View.elm Outdated Show resolved Hide resolved
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noticed we don't have tests for the view even prior to this PR? we should add a story to follow up after this to add them.

@claire1618 claire1618 merged commit edd0959 into main Jan 15, 2024
12 checks passed
@claire1618 claire1618 deleted the feat/deploymentsTableTest branch January 15, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants