Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api/user): add endpoint for viewing builds sent by current user #989

Closed
wants to merge 2 commits into from

Conversation

ecrupper
Copy link
Contributor

This would allow for the creation of a "Your Builds" page in the UI, which I think would be really convenient for our users.

Pretty slim related issue: go-vela/community#551

This query would be very taxing without introducing an index on sender for the builds table, which is the approach I took here.

@ecrupper ecrupper requested a review from a team as a code owner October 17, 2023 20:36
@ecrupper ecrupper self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #989 (3054bfe) into main (d90fdb7) will decrease coverage by 0.57%.
Report is 2 commits behind head on main.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   71.10%   70.53%   -0.57%     
==========================================
  Files         313      316       +3     
  Lines       13028    13207     +179     
==========================================
+ Hits         9263     9316      +53     
- Misses       3299     3421     +122     
- Partials      466      470       +4     
Files Coverage Δ
database/build/count_sender.go 100.00% <100.00%> (ø)
database/build/index.go 42.85% <40.00%> (-4.21%) ⬇️
database/build/list_sender.go 79.54% <79.54%> (ø)
api/build/list_sender.go 0.00% <0.00%> (ø)

@ecrupper
Copy link
Contributor Author

Closing this. I think we'll prefer dashboards over a page like this for the time being. May revisit at some point.

@ecrupper ecrupper closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants