Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(secrets)!: use the same allow_events system as repos for secrets #1033

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Jan 5, 2024

Follow up from go-vela/types#341

Keeping events around for now in order for the fallback option without data loss. In v0.24, that column should be dropped.

@ecrupper ecrupper requested a review from a team as a code owner January 5, 2024 18:32
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de5cf10) 67.01% compared to head (b47fa6b) 67.04%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   67.01%   67.04%   +0.02%     
==========================================
  Files         330      330              
  Lines       14080    14092      +12     
==========================================
+ Hits         9436     9448      +12     
  Misses       4165     4165              
  Partials      479      479              
Files Coverage Δ
database/secret/table.go 100.00% <ø> (ø)
secret/native/update.go 64.40% <100.00%> (+1.90%) ⬆️
secret/vault/vault.go 96.56% <100.00%> (+0.15%) ⬆️

@ecrupper ecrupper merged commit 78eca51 into main Jan 5, 2024
14 of 15 checks passed
@ecrupper ecrupper deleted the enhance/secrets/allow-events branch January 5, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants