Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): refactor to run db integration test as matrix #1018

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Dec 1, 2023

closes #967

split postgres and sqlite testing so that we can matrix test postgres versions to adhere to n-1 compatibility.

note: not sure what renovate will do here, so might have to adjustments once we find out. potentially a little more overhead if renovate doesn't update for us anymore, though maybe there's a way to configure it to still handle this scenario.

@wass3r wass3r requested a review from a team as a code owner December 1, 2023 02:49
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #1018 (537058b) into main (fb12fdd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   68.36%   68.36%           
=======================================
  Files         317      317           
  Lines       13641    13641           
=======================================
  Hits         9326     9326           
  Misses       3848     3848           
  Partials      467      467           

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3rw3rk wass3rw3rk merged commit 5e1a7d3 into main Dec 6, 2023
14 of 15 checks passed
@wass3rw3rk wass3rw3rk deleted the test/matrix_integration branch December 6, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants