fix: changing ProcessWebhook so that the deployment ref is only set o…

…nce (#1054) Co-authored-by: Claire.Nicholas <[email protected]>
go-vela · Feb 2, 2024 · f2f177c · f2f177c
1 parent b4d810d
commit f2f177c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/scm/github/webhook.go b/scm/github/webhook.go
@@ -412,8 +412,6 @@ func (c *client) processDeploymentEvent(h *library.Hook, payload *github.Deploym
 		fmt.Sprintf("https://%s/%s/settings/hooks", h.GetHost(), r.GetFullName()),
 	)
 
-	d.SetRef(b.GetRef())
-
 	return &types.Webhook{
 		Hook:       h,
 		Repo:       r,

diff --git a/scm/github/webhook_test.go b/scm/github/webhook_test.go
@@ -565,7 +565,7 @@ func TestGithub_ProcessWebhook_Deployment(t *testing.T) {
 	wantDeployment.SetNumber(145988746)
 	wantDeployment.SetURL("https://api.github.com/repos/Codertocat/Hello-World/deployments/145988746")
 	wantDeployment.SetCommit("f95f852bd8fca8fcc58a9a2d6c842781e32a215e")
-	wantDeployment.SetRef("refs/heads/main")
+	wantDeployment.SetRef("main")
 	wantDeployment.SetTask("deploy")
 	wantDeployment.SetTarget("production")
 	wantDeployment.SetDescription("")
@@ -698,7 +698,7 @@ func TestGithub_ProcessWebhook_Deployment_Commit(t *testing.T) {
 	wantDeployment.SetNumber(145988746)
 	wantDeployment.SetURL("https://api.github.com/repos/Codertocat/Hello-World/deployments/145988746")
 	wantDeployment.SetCommit("f95f852bd8fca8fcc58a9a2d6c842781e32a215e")
-	wantDeployment.SetRef("refs/heads/main")
+	wantDeployment.SetRef("f95f852bd8fca8fcc58a9a2d6c842781e32a215e")
 	wantDeployment.SetTask("deploy")
 	wantDeployment.SetTarget("production")
 	wantDeployment.SetDescription("")