Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove types dependency #338

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

Follow up from go-vela/server#1213

@ecrupper ecrupper requested a review from a team as a code owner October 22, 2024 14:13
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (0d47b45) to head (8cdfc24).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          22       22           
  Lines        1634     1634           
=======================================
  Hits         1492     1492           
  Misses        106      106           
  Partials       36       36           
Files with missing lines Coverage Δ
vela/admin.go 96.55% <100.00%> (ø)
vela/authentication.go 84.89% <100.00%> (ø)
vela/build.go 92.15% <100.00%> (ø)
vela/client.go 90.96% <100.00%> (ø)
vela/dashboard.go 100.00% <100.00%> (ø)
vela/deployment.go 91.89% <100.00%> (ø)
vela/hook.go 94.91% <100.00%> (ø)
vela/log.go 100.00% <100.00%> (ø)
vela/pipeline.go 77.61% <100.00%> (ø)
vela/queue.go 100.00% <100.00%> (ø)
... and 6 more

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit b9de2ce into main Oct 22, 2024
10 of 11 checks passed
@ecrupper ecrupper deleted the refactor/nested-api/log-and-misc branch October 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants