feat: Align algorith to aquire tokens with goreleaser #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an inconsistency between
provider-gitlab
andhook-goreleaser
when running in ci.hook-goreleaser
(and plaingoreleaser
) getsGITLAB_TOKEN
, which is then checked againstCI_JOB_TOKEN
variable later in code. It then uses different API constructor calls to upload the release. It fails to findGITLAB_TOKEN
, it will fail the release process.provider-gitlab
uses blindlyGITLAB_TOKEN
and assumes it is a valid api token. If it is missing, it usesCI_JOB_TOKEN
with git repo. This fails in a situation whereGITLAB_TOKEN == CI_JOB_TOKEN
, sinceCI_JOB_TOKEN
does NOT have access to the needed APIs.This situation creates an impasse to run
semantic-release
withhook-goreleaser
in Gitlab-CI with just a job token. This PR fixes this problem by aligning token fetching algorithms.