Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trailing NULL bytes in buffer while detecting a content type #779

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Mar 2, 2024

Closes #754

@jeevatkm jeevatkm added the bug label Mar 2, 2024
@jeevatkm jeevatkm added this to the v2.12.0 milestone Mar 2, 2024
@jeevatkm jeevatkm self-assigned this Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (97187c4) to head (eb7cac7).

Additional details and impacted files
@@           Coverage Diff           @@
##               v2     #779   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          12       12           
  Lines        1643     1643           
=======================================
  Hits         1585     1585           
  Misses         37       37           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit 0ac42a2 into v2 Mar 2, 2024
4 checks passed
renovate bot referenced this pull request in Michsior14/transmission-gluetun-port-update Mar 18, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/go-resty/resty/v2](https://togithub.com/go-resty/resty) |
`v2.11.0` -> `v2.12.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-resty%2fresty%2fv2/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-resty%2fresty%2fv2/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-resty%2fresty%2fv2/v2.11.0/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-resty%2fresty%2fv2/v2.11.0/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>go-resty/resty (github.com/go-resty/resty/v2)</summary>

###
[`v2.12.0`](https://togithub.com/go-resty/resty/releases/tag/v2.12.0)

[Compare
Source](https://togithub.com/go-resty/resty/compare/v2.11.0...v2.12.0)

### Release Notes

#### Enhancements

- Add Client.Clone function by
[@&#8203;fabiante](https://togithub.com/fabiante) in
[https://github.com/go-resty/resty/pull/774](https://togithub.com/go-resty/resty/pull/774)

#### Bug Fixes

- Fixed JSON request logging data race. by
[@&#8203;buglloc](https://togithub.com/buglloc) in
[https://github.com/go-resty/resty/pull/775](https://togithub.com/go-resty/resty/pull/775)
- fix: trailing NULL bytes in buffer while detecting a content type by
[@&#8203;jeevatkm](https://togithub.com/jeevatkm) in
[https://github.com/go-resty/resty/pull/779](https://togithub.com/go-resty/resty/pull/779)
- fix: encode path params with BaseURL and the first param at index zero
([#&#8203;781](https://togithub.com/go-resty/resty/issues/781)) by
[@&#8203;sakateka](https://togithub.com/sakateka) in
[https://github.com/go-resty/resty/pull/782](https://togithub.com/go-resty/resty/pull/782)

#### Documentation

- fix: doc typo by
[@&#8203;victoraugustolls](https://togithub.com/victoraugustolls) in
[https://github.com/go-resty/resty/pull/769](https://togithub.com/go-resty/resty/pull/769)
- docs: replace `SetHostURL` to `SetBaseURL` by
[@&#8203;purofle](https://togithub.com/purofle) in
[https://github.com/go-resty/resty/pull/772](https://togithub.com/go-resty/resty/pull/772)
- for v2.12.0 release by
[@&#8203;jeevatkm](https://togithub.com/jeevatkm) in
[https://github.com/go-resty/resty/pull/783](https://togithub.com/go-resty/resty/pull/783)

#### New Contributors

- [@&#8203;victoraugustolls](https://togithub.com/victoraugustolls) made
their first contribution in
[https://github.com/go-resty/resty/pull/769](https://togithub.com/go-resty/resty/pull/769)
- [@&#8203;purofle](https://togithub.com/purofle) made their first
contribution in
[https://github.com/go-resty/resty/pull/772](https://togithub.com/go-resty/resty/pull/772)
- [@&#8203;buglloc](https://togithub.com/buglloc) made their first
contribution in
[https://github.com/go-resty/resty/pull/775](https://togithub.com/go-resty/resty/pull/775)
- [@&#8203;fabiante](https://togithub.com/fabiante) made their first
contribution in
[https://github.com/go-resty/resty/pull/774](https://togithub.com/go-resty/resty/pull/774)
- [@&#8203;sakateka](https://togithub.com/sakateka) made their first
contribution in
[https://github.com/go-resty/resty/pull/782](https://togithub.com/go-resty/resty/pull/782)

**Full Changelog**:
go-resty/resty@v2.11.0...v2.12.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Michsior14/transmission-gluetun-port-update).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jeevatkm jeevatkm deleted the gh-754 branch September 12, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Call to http.DetectContentType has trailing NUL bytes in buffer
1 participant