Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log level to warning for errors within retry block #587

Merged
merged 4 commits into from
Sep 17, 2023

Conversation

sandyydk
Copy link
Contributor

@sandyydk sandyydk commented Oct 3, 2022

Closes #561
Closes #554

@sandyydk
Copy link
Contributor Author

sandyydk commented Oct 3, 2022

This fixes the issue
#561

@jeevatkm

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandyydk Thanks for your PR and contribution. I'm sorry for the delayed attention on the PR.
Can you resolve the code conflicts?

@sandyydk
Copy link
Contributor Author

sandyydk commented Mar 6, 2023

Sure will update this. Thanks for the response.

@jeevatkm
Copy link
Member

@sandyydk Just wanted to check. Are you planning to update this PR? if not let me know, I will take it up and prepare for next release.

@sandyydk sandyydk requested a review from jeevatkm May 5, 2023 17:54
@sandyydk
Copy link
Contributor Author

sandyydk commented May 5, 2023

@sandyydk Just wanted to check. Are you planning to update this PR? if not let me know, I will take it up and prepare for next release.

@jeevatkm Sorry for the delayed response. Resolved the conflicts. Can you take a look now? Thanks.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandyydk Thanks for you PR, appreciated.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (15cedd4) 95.73% compared to head (8e34ee4) 95.68%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   95.73%   95.68%   -0.05%     
==========================================
  Files          11       11              
  Lines        1571     1600      +29     
==========================================
+ Hits         1504     1531      +27     
  Misses         41       41              
- Partials       26       28       +2     
Files Changed Coverage Δ
request.go 95.28% <100.00%> (+0.13%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit e12ab69 into go-resty:master Sep 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Warn-level logging on retries attempts
2 participants