Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customized redis key prefix #74

Open
wants to merge 1 commit into
base: v9
Choose a base branch
from
Open

Support customized redis key prefix #74

wants to merge 1 commit into from

Conversation

dcb9
Copy link

@dcb9 dcb9 commented Apr 8, 2022

Fixed key prefix limits the project potential in a complex situation

@ovdienkonikolai
Copy link

Hello, this issue is relevant to us, we would like to see these changes in the main branch. What's preventing the merge?

@freddierice
Copy link

I'm also interested in this feature.

I'm not a maintainer, but it looks like you're breaking the type signature of the Limiter constructor. Another approach could be to add limiter options, for example:

type LimiterOpt func(*Limiter)
func NewLimiter(rdb rediser, opts ...LimiterOpt) *Limiter {
     ...
}

@dcb9
Copy link
Author

dcb9 commented Jan 26, 2024

@freddierice I totally agree with you, I'll change the approach to option pattern without changing default behavior.

@dcb9 dcb9 changed the title Remove global key prefix constant Support customized redis key prefix Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants