Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Support for multiple return values from go function to python #282

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

[Draft] Support for multiple return values from go function to python #282

wants to merge 21 commits into from

Commits on Jun 19, 2022

  1. Merge pull request #1 from rudderlabs/nisshar/VariadicFunctions 

    Support for variadic functions
    @nishantsharma
    nishantsharma authored Jun 19, 2022
    Configuration menu
    Copy the full SHA
    1fe3270 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Go module path updated so that it can be installed.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    399dd4b View commit details
    Browse the repository at this point in the history

  2. Replacing gopy URL so that it works in forks too.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    f6c26ce View commit details
    Browse the repository at this point in the history

  3. go package to test is at rudderlabs/gopy

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    4ea0c07 View commit details
    Browse the repository at this point in the history

  4. Added test code for multireturn.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    3e19314 View commit details
    Browse the repository at this point in the history

  5. First stage changes made. Next step is to change the loop to reflect … 

    …original design.
    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    d0d0d65 View commit details
    Browse the repository at this point in the history

  6. Python code being generated sensibly.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b5b07fe View commit details
    Browse the repository at this point in the history

  7. Correcting npyres computation.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    c57ef41 View commit details
    Browse the repository at this point in the history

  8. Verfied generated python code, atleast for smaller ret-counts.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b3c7b5d View commit details
    Browse the repository at this point in the history

  9. Code to handle multiple return values as tuples now logically complet… 

    …e, even though it doesn't work currently.
    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    d93d069 View commit details
    Browse the repository at this point in the history

  10. Both go and python code is now compiling. Automatic Test are failing.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1ae7696 View commit details
    Browse the repository at this point in the history

  11. Working quite a bit as expected. But, some memory corruption is causi… 

    …ng un-expected memory freeing and crashes.
    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    05d1874 View commit details
    Browse the repository at this point in the history

  12. Tests passing once we let memory leak. Fix for memory leaks to be car… 

    …efully enabled.
    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1e11675 View commit details
    Browse the repository at this point in the history

  13. Ignoring functions returning functions.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    14d81b4 View commit details
    Browse the repository at this point in the history

  14. __err was getting reused in a way which declarations difficult. Fixed.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    2cb06f8 View commit details
    Browse the repository at this point in the history

  15. Fixed a few code generation error for methods.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1a54a50 View commit details
    Browse the repository at this point in the history

  16. Python None now mapped to GoLang nil.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    9350594 View commit details
    Browse the repository at this point in the history

  17. TestGovet and TestGofmt now passing.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    ea0d913 View commit details
    Browse the repository at this point in the history

  18. Crash in gen command fixed.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    9020e61 View commit details
    Browse the repository at this point in the history

  19. gopyerrors is not applicable any more.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    a44f1e5 View commit details
    Browse the repository at this point in the history

  20. Test failure bug fixed.

    @nishant-rudderstack
    nishant-rudderstack committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    35cda9d View commit details
    Browse the repository at this point in the history