-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caches metric can be missalloccated too #54
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,9 @@ import ( | |
|
||
// import "github.com/go-graphite/buckytools/hashing" | ||
|
||
var inconsistentFilterCacheMetrics bool | ||
var inconsistentGoCarbonMetricsPrefix string | ||
|
||
func init() { | ||
usage := "[options]" | ||
short := "Find metrics not in correct locations." | ||
|
@@ -36,6 +39,8 @@ Use bucky rebalance to correct.` | |
"Force the remote daemons to rebuild their cache.") | ||
c.Flag.BoolVar(&listRegexMode, "r", false, | ||
"Filter by a regular expression.") | ||
c.Flag.BoolVar(&inconsistentFilterCacheMetrics, "filter-cache-metrics", true, "Filter go-carbon inconsistent metrics.") | ||
c.Flag.StringVar(&inconsistentGoCarbonMetricsPrefix, "go-carbon-prefix", "carbon.agents.", "go-carbon metric prefix") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. c.Flag.StringVar(&goCarbonMetricsPrefix, "go-carbon-prefix", "carbon.agents.", "go-carbon metric prefix") |
||
} | ||
|
||
func InconsistentMetrics(hostports []string, regex string) (map[string][]string, error) { | ||
|
@@ -63,9 +68,9 @@ func InconsistentMetrics(hostports []string, regex string) (map[string][]string, | |
} | ||
|
||
for _, m := range metrics { | ||
if strings.HasPrefix(m, "carbon.agents.") { | ||
// These metrics are inserted into the stream after hashing | ||
// is done. They will never be consistent and shouldn't be. | ||
if inconsistentFilterCacheMetrics && strings.HasPrefix(m, inconsistentGoCarbonMetricsPrefix) { | ||
// Graphite cache metrics (usually "carbon.agents.*" metrics) can be inserted into the stream | ||
// after hashing has been completed (if written locally). In this case, they will never be consistent and shouldn't be. | ||
continue | ||
} | ||
if Cluster.Hash.GetNode(m).Server != host { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,8 @@ Set -offload=true to speed up rebalance.` | |
c.Flag.BoolVar(&listForce, "f", false, "Force the remote daemons to rebuild their cache.") | ||
c.Flag.StringVar(&rebalanceConfig.allowedDsts, "allowed-dsts", "", "Only copy/rebalance metrics to the allowed destinations (ip1:port,ip2:port). By default (i.e. empty), all dsts are allowed.") | ||
c.Flag.StringVar(&rebalanceConfig.allowedMetricRegex, "r", "", "Only copy/rebalance metrics matching regex. By default (i.e. empty), all metrics are allowed.") | ||
c.Flag.BoolVar(&inconsistentFilterCacheMetrics, "filter-cache-metrics", true, "Filter go-carbon inconsistent metrics.") | ||
c.Flag.StringVar(&inconsistentGoCarbonMetricsPrefix, "go-carbon-prefix", "carbon.agents.", "go-carbon metric prefix") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. c.Flag.StringVar(&goCarbonMetricsPrefix, "go-carbon-prefix", "carbon.agents.", "go-carbon metric prefix") |
||
} | ||
|
||
// countMap returns the number of metrics in a server -> metrics mapping | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just
goCarbonMetricsPrefix
?