Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refactor: refactor funcs with generics #1123

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

feat: rm test

ecd818a
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

WIP: refactor: refactor funcs with generics #1123

feat: rm test
ecd818a
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci failed Jan 15, 2025 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (3)

generics.go|227 col 9| indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
generics.go|237 col 9| indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
generics.go|247 col 9| indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)

Filtered Findings (0)

Annotations

Check failure on line 227 in generics.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] generics.go#L227

indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
Raw output
generics.go:227:9: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
	} else {
		return result.(E), nil
	}

Check failure on line 237 in generics.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] generics.go#L237

indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
Raw output
generics.go:237:9: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
	} else {
		return result.(E), nil
	}

Check failure on line 247 in generics.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] generics.go#L247

indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
Raw output
generics.go:247:9: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
	} else {
		return result.(E), nil
	}