-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rename branch API #32433
Open
kemzeb
wants to merge
7
commits into
go-gitea:main
Choose a base branch
from
kemzeb:feat-api-add-rename-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement rename branch API #32433
+216
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 6, 2024
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 6, 2024
github-actions
bot
added
modifies/api
This PR adds API routes or modifies them
modifies/go
Pull requests that update Go code
labels
Nov 6, 2024
kemzeb
commented
Nov 6, 2024
kemzeb
commented
Nov 6, 2024
silverwind
added
the
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
label
Nov 6, 2024
lunny
reviewed
Nov 6, 2024
Co-authored-by: sillyguodong <[email protected]>
kemzeb
force-pushed
the
feat-api-add-rename-branch
branch
from
November 17, 2024 02:12
1beebeb
to
36829ec
Compare
wxiaoguang
reviewed
Nov 17, 2024
lunny
reviewed
Nov 18, 2024
lunny
reviewed
Nov 19, 2024
// | ||
// required: true | ||
// unique: true | ||
Name string `json:"name" binding:"Required;GitRefName;MaxSize(100)"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR. But why is the max size 100 for every API request? Maybe it should be 255.
lunny
approved these changes
Nov 19, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
modifies/api
This PR adds API routes or modifies them
modifies/go
Pull requests that update Go code
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22526.
Builds upon #23061.