-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description option : override + default description contains the list of middlewares #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenQuim
commented
Dec 13, 2024
dylanhitt
reviewed
Dec 13, 2024
I was more asking about the naming of the function. Why change to Add vs just |
EwenQuim
force-pushed
the
refactor-register-controller
branch
2 times, most recently
from
December 13, 2024 23:58
7ea6109
to
667dae2
Compare
EwenQuim
changed the title
Refactored the Description/AddDescription to a clearer system
Refactored the Description option and Default description
Dec 13, 2024
EwenQuim
changed the title
Refactored the Description option and Default description
Description option : override + default description contains the list of middlewares
Dec 14, 2024
EwenQuim
force-pushed
the
refactor-register-controller
branch
from
December 14, 2024 00:49
cbd1966
to
59f7953
Compare
EwenQuim
force-pushed
the
refactor-register-controller
branch
from
December 14, 2024 00:53
59f7953
to
3c4db6b
Compare
dylanhitt
reviewed
Dec 14, 2024
dylanhitt
approved these changes
Dec 14, 2024
ccoVeille
reviewed
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.