Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description option : override + default description contains the list of middlewares #275

Merged
merged 8 commits into from
Dec 14, 2024

Conversation

EwenQuim
Copy link
Member

No description provided.

openapi.go Show resolved Hide resolved
@EwenQuim
Copy link
Member Author

EwenQuim commented Dec 13, 2024

The end goal is to have this default description :

image

A user might want the ability to disable or override it.

Perhaps providing a route-level option to disable it would be a better solution?

@dylanhitt
Copy link
Collaborator

I was more asking about the naming of the function. Why change to Add vs just Description. You seem to be overriding.

@EwenQuim EwenQuim force-pushed the refactor-register-controller branch 2 times, most recently from 7ea6109 to 667dae2 Compare December 13, 2024 23:58
@EwenQuim EwenQuim changed the title Refactored the Description/AddDescription to a clearer system Refactored the Description option and Default description Dec 13, 2024
@EwenQuim EwenQuim requested a review from dylanhitt December 14, 2024 00:00
@EwenQuim EwenQuim changed the title Refactored the Description option and Default description Description option : override + default description contains the list of middlewares Dec 14, 2024
@EwenQuim EwenQuim force-pushed the refactor-register-controller branch from cbd1966 to 59f7953 Compare December 14, 2024 00:49
@EwenQuim EwenQuim force-pushed the refactor-register-controller branch from 59f7953 to 3c4db6b Compare December 14, 2024 00:53
mux.go Outdated Show resolved Hide resolved
option.go Show resolved Hide resolved
openapi.go Outdated Show resolved Hide resolved
openapi.go Show resolved Hide resolved
option.go Outdated Show resolved Hide resolved
mux.go Outdated Show resolved Hide resolved
@EwenQuim EwenQuim merged commit a256a7c into main Dec 14, 2024
7 checks passed
@EwenQuim EwenQuim deleted the refactor-register-controller branch December 14, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants