Golden file testing #148
Merged
Golden file testing #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
EwenQuim
commented
Jul 22, 2024
EwenQuim
force-pushed
the
golden-file-testing
branch
from
0ed93c2 to
d727b7a
Compare
dylanhitt
approved these changes
Jul 22, 2024
|
My only comment is we should probably add a check in the CI to ensure the golden-file is being updated. The CI check shouldn't update the file, but it would just fail until the author of the MR updated it. |
|
If the golden file isn't updated and it should, the tests will fail, so no issue here :) |
EwenQuim
force-pushed
the
golden-file-testing
branch
from
d727b7a to
fd0d577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds golden file testing, and vacuum for schema validation.
This helps tracks the generated OpenAPI schema when making change on the generation