filesystem: Bubble up errors rather than panicing

filesystem.go

@@ -4,7 +4,6 @@ import (
  "fmt"
  "io"
  "io/ioutil"
- "log"
  "os"
  "path"
  "path/filepath"
@@ -70,18 +69,18 @@ func CopyTree(sourcetree, desttree string) error {
  case 0:
  err := CopyFile(p, target, info.Mode())
  if err != nil {
- log.Panicf("Failed to copy file %s: %v", p, err)
+ return fmt.Errorf("Failed to copy file %s: %w", p, err)
  }
  case os.ModeDir:
  os.Mkdir(target, info.Mode())
  case os.ModeSymlink:
  link, err := os.Readlink(p)
  if err != nil {
- log.Panicf("Failed to read symlink %s: %v", suffix, err)
+ return fmt.Errorf("Failed to read symlink %s: %w", suffix, err)
  }
  os.Symlink(link, target)
  default:
- log.Panicf("Not handled /%s %v", suffix, info.Mode())
+ return fmt.Errorf("File %s with mode %v not handled", p, info.Mode())
  }
 
  return nil

tests/overlay-non-existent-destination/overlay-non-existent-destination.yaml

@@ -0,0 +1,17 @@
+architecture: amd64
+
+actions:
+ # This overlay action is expected to error out here because the destination
+ # doesn't exist in the filesystem.
+ - action: overlay
+ description: Overlay file into a non-existent destination
+ source: overlay-non-existent-destination.yaml
+ destination: /this/path/does/not/exist/overlay-non-existent-destination.yaml
+
+ - action: run
+ description: Check if path exists
+ command: "[ -e /this/path/does/not/exist/overlay-non-existent-destination.yaml ] || exit 1"
+
+ - action: run
+ postprocess: true
+ command: echo Test