Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionos: follow CNAME #2281

Merged
merged 3 commits into from
Sep 19, 2024
Merged

ionos: follow CNAME #2281

merged 3 commits into from
Sep 19, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 19, 2024

Ping @markusm7, can you run the command (with your domain, email, credentials, etc.)?

make build
rm -rf .lego

IONOS_API_KEY=xxxxxxxx \
./dist/lego -m [email protected] --dns ionos -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

Note the wildcard domain is important.

Fixes #2280

@markusm7
Copy link

markusm7 commented Sep 19, 2024

Tested it, I think there is still a problem as the FQDN returned from my CNAME record ends with a . as a termination sign for the domain name (e.g. customer.challenge.example.com.) and the check in the findZone seems to neglect that possibility as the zones returned from ionos don't have that
https://github.com/ldez/lego/blob/dee89eea7dc2cd4b0b452b2c736819b07fbe47ad/providers/dns/ionos/ionos.go#L188-L194

I can't remove the dot in the CNAME record and if I remember correctly it's a common practive to terminate domains with a dot

@ldez
Copy link
Member Author

ldez commented Sep 19, 2024

I updated to PR, can you try again?

@markusm7
Copy link

It works 👍

@ldez ldez removed the state/need-user-tests Need users to test functionality label Sep 19, 2024
@ldez ldez marked this pull request as ready for review September 19, 2024 12:53
@ldez
Copy link
Member Author

ldez commented Sep 19, 2024

I hope you enjoyed my work, please consider donating or asking your company to do so.
This will be appreciated, thank you ❤️

https://github.com/sponsors/ldez

@ldez ldez requested a review from dmke September 19, 2024 13:01
@ldez ldez added this to the v4.19 milestone Sep 19, 2024
@ldez ldez merged commit 69bd2e0 into go-acme:master Sep 19, 2024
4 checks passed
@ldez ldez deleted the feat/ionos-cname branch September 19, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants