Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant a_generic kernels #685

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Conversation

argilo
Copy link
Member

@argilo argilo commented Oct 24, 2023

Also, rename u_generic to generic.

After this change, every kernel has exactly one generic protokernel, except for volk_32u_reverse_32u, which never had a generic protokernel.

Update: volk_32u_reverse_32u now has a generic protokernel as well. See below for details.

Fixes #516.

Also, rename u_generic to generic.

Signed-off-by: Clayton Smith <[email protected]>
@argilo
Copy link
Member Author

argilo commented Oct 24, 2023

The test failure is unrelated; it's #676.

@argilo
Copy link
Member Author

argilo commented Oct 24, 2023

This change will also help with #516 (since more kernels will have generic), but it's still not fully resolved until either:

  • every kernel has generic and we enforce that in volk_kernel_defs.py; or
  • code that depends on generic existing is removed.

@argilo
Copy link
Member Author

argilo commented Oct 24, 2023

I asked about this in the VOLK Matrix channel and didn't hear any objections to the first option. So I renamed volk_32u_reverse_32u_dword_shuffle to volk_32u_reverse_32u_generic, giving every kernel a generic implementation, and added an enforcement mechanism to volk_kernel_defs.py.

Copy link
Contributor

@jdemel jdemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, this fixes #516 .

@jdemel jdemel merged commit fd0dec8 into gnuradio:main Nov 4, 2023
33 checks passed
@argilo argilo deleted the fix-generic branch December 2, 2023 16:47
Alesha72003 pushed a commit to Alesha72003/volk that referenced this pull request May 15, 2024
Remove redundant a_generic kernels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volk_get_index broken, stuck in infinite loop
2 participants