Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PoC Of Router #10

Merged
merged 7 commits into from
Sep 4, 2024
Merged

feat: PoC Of Router #10

merged 7 commits into from
Sep 4, 2024

Conversation

tolelom
Copy link
Collaborator

@tolelom tolelom commented Sep 4, 2024

추가 사항

  • PoC에서 라우팅 최대 경로 제한 옵션 추가(findRouteV2)
  • findRouteV2에 대한 테스트 추가
  • 간단한 주석 추가

@tolelom tolelom requested a review from notJoon September 4, 2024 05:05
notJoon
notJoon requested changes Sep 4, 2024
View reviewed changes
poc/my_router_test.go Outdated Show resolved Hide resolved
poc/my_router_test.go Outdated Show resolved Hide resolved
@notJoon
Copy link
Member

notJoon commented Sep 4, 2024

테스트 케이스에 이름만 추가해주시면 좋을 것 같습니다. 구현은 좋아요 👍

tolelom and others added 2 commits September 4, 2024 14:49
@tolelom @notJoon
Update poc/my_router_test.go
e49d95d 
Co-authored-by: Lee ByeongJun <[email protected]>
@tolelom @notJoon
Update poc/my_router_test.go
65af84c 
Co-authored-by: Lee ByeongJun <[email protected]>
@tolelom
Copy link
Collaborator Author

tolelom commented Sep 4, 2024

테스트 케이스에 이름만 추가해주시면 좋을 것 같습니다. 구현은 좋아요 👍

감사합니다 :D

@tolelom tolelom requested a review from notJoon September 4, 2024 06:00
tolelom
tolelom commented Sep 4, 2024
View reviewed changes
Copy link
Collaborator Author

@tolelom tolelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@notJoon notJoon merged commit 9c28f2e into main Sep 4, 2024
3 checks passed
@notJoon notJoon deleted the tolelom branch September 4, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tolelom @notJoon