Testing setup #36
Merged
Testing setup #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
Dec 4, 2024
| | "eip1559.json" | ||
| | "mergeTest.json" | ||
|
|
||
| // These tests are passing, but they take a lot of time to execute so we are going to skip them. |
There was a problem hiding this comment.
as long as it's running now (10 mins)
we don't exclude any tests now (not the false &&)
dapplion
reviewed
Dec 4, 2024
| general_state_test!(st_stack, stStackTests); | ||
| general_state_test!(st_static_call, stStaticCall); // passing, but conflicts with rewards contract | ||
| general_state_test!(st_transaction, stTransactionTest); | ||
| general_state_test!(vm_tests, VMTests); |
There was a problem hiding this comment.
apart from eip 1559, withdrawals, tests rn fail for 2 main reasons:
- wrong impl on our end
- the test "should fail" and it is faililng, but the exact error string in reth (ExecutionStageError.MaxGasReached) is different than in exec specs (MAX_GAS_REACHED, for eg)
dapplion
approved these changes
Dec 4, 2024
|
I'll merge as is, we can work on passing more tests in another branch |
dapplion
reviewed
Dec 4, 2024
.github/workflows/test.yml
Outdated
| - name: Downloading ethereum/tests | ||
| run: git clone https://github.com/ethereum/tests ethereum-tests | ||
| - name: Downloading EELS fixtures released at Cancun | ||
| run: curl -LO https://github.com/ethereum/execution-spec-tests/releases/download/v2.1.1/fixtures.tar.gz && tar -xzf fixtures.tar.gz |
There was a problem hiding this comment.
Was going to suggest caching, but this is very fast already
There was a problem hiding this comment.
the curl -LO is done within a sec, but git clone does take some time tbh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds necessary handlers and drivers for testing with ethereum/tests and the new eels tests.
failing-testsfeature (25%).This PR is targeted mostly at setting up the code needed to run the EELS or ethereum tests. The tests themselves will be kept updated as and when Gnosis tests are available. The tests currently passing is just to prove that we aren't doing anything wildly wrong.