Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EIP4895 vectors and update block processing scripts #34

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

debjit-bw
Copy link
Member

  • Adds scripts to generate test vectors (containing withdrawals) against Nethermind
  • Applies them to Reth
  • Timestamps for the Shanghai updated

@debjit-bw debjit-bw marked this pull request as ready for review November 29, 2024 17:49
@debjit-bw debjit-bw requested a review from dapplion November 29, 2024 17:49
@dapplion
Copy link
Member

dapplion commented Dec 4, 2024

When adding a giant blob for a transaction please document where it comes from! Otherwise it's hard to debug or replicate latter. Please do in a follow up PR

@dapplion dapplion merged commit 84b7c5a into master Dec 4, 2024
6 checks passed
@dapplion dapplion deleted the withdrawals-block-pattern branch December 4, 2024 11:30
debjit-bw added a commit that referenced this pull request Dec 4, 2024
* feat: add EIP4895 vectors and update block processing scripts

* fix: update script to apply EIP4895 vectors instead of EIP1559 blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants