chore: In gnoclient, separate out SignTx and BroadcastTxCommit #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2641 +/- ##
==========================================
+ Coverage 60.19% 60.24% +0.04%
==========================================
Files 562 562
Lines 75007 75038 +31
==========================================
+ Hits 45154 45210 +56
+ Misses 26476 26457 -19
+ Partials 3377 3371 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…d BroadcastTxCommit Also add MakeCallTx, MakeRunTx, MakeSendTx and MakeAddPackageTx to support signing separately. Signed-off-by: Jeff Thompson <[email protected]>
jefft0
force-pushed
the
chore/gnoclient-add-SignTx-BroadcastTxCommit-MakeCallTx-etc
branch
from
795277a
to
10550df
Compare
thehowl
reviewed
Jul 31, 2024
jefft0
added a commit
to gnolang/gnonative
that referenced
this pull request
Aug 2, 2024
…use temporary replace for gno PR 2641 (#161) PR gnolang/gno#2641 updates the `gnoclient` API to add `MakeCallTx`, etc. and `SignTx` and `BroadcastTxCommit`. We want to support these in the gnonative API. * In go.mod, add a replace for github.com/gnolang/gno to the branch of PR gnolang/gno#2641 * In gnonativetypes.go, add field `CallerAddress` to `CallRequest`, `SendRequest` and `RunRequest`. Add `MakeTxResponse` and request/response for `SignTx` and `BroadcastTxCommitResponse`. * In rpc.proto, add `MakeCallTx`, etc., `SignTx` and `BroadcastTxCommit`. * Run `make regenerate` . * In api.go, split out helper function `convertCallRequest` from `Call`. Do the same for `convertSendRequest` and `convertRunRequest`. Add `MakeCallTx` which also uses `convertCallRequest`. Do the same for `MakeSendTx` and `MakeRunTx`. Add `SignTx` and `BroadcastTxCommit`. * Note that `MakeCallTx` converts the tx structure to JSON using `amino.MarshalJSON(tx)` . This is the same thing as done by the command-line `gnokey maketx call` . Signed-off-by: Jeff Thompson <[email protected]>
…it-MakeCallTx-etc
…unSigningSeparately Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
…it-MakeCallTx-etc
…it-MakeCallTx-etc
zivkovicmilos
requested changes
Aug 19, 2024
…it-MakeCallTx-etc
…it-MakeCallTx-etc
Signed-off-by: Jeff Thompson <[email protected]>
…lTx, etc. Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
zivkovicmilos
approved these changes
Aug 23, 2024
|
Pinging @gfanton for a second review 🙏 |
…it-MakeCallTx-etc
gfanton
approved these changes
Aug 23, 2024
Thanks for the review. No, I don't think we need to expose SignAndBroadcastTx. The use case for separating out SignTx is for airgap signing (or signing with a different app like Gnokey Mobile). In this use case, sign and broadcast are done on different devices or apps. |
jefft0
added a commit
to gnolang/gnonative
that referenced
this pull request
Aug 29, 2024
Gno PR gnolang/gno#2641 has been merged, so we don't need the go.mod replace which was introduced in PR #161 . * In go.mod, remove the replace and use the latest gnolang/gno. * The final gnoclient API which was merged in PR gnolang/gno#2641 is different. It uses `vm.MsgCall`, etc. instead of `gnoclient.MsgCall`, and uses `NewCallTx`, etc. instead of `MakeCallTx`. Therefore, this PR updates api.go to use the new API. * Change the helper functions `convertCallRequest`, etc. to maybe return an error if there is no active account, or if the `send` amount like "1000ugnot" can't be parsed. Signed-off-by: Jeff Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
gnokey maketx call,gnokey signandgnokey broadcastto make a transaction and sign it separately before broadcast. We want to support the same thing in thegnoclientAPI. (And we want to expose this API in Gno Native Kit.)NewCallTxfromCallNewRunTxfromRunNewSendTxfromSendNewAddPackageTxfromAddPackageSignTxandBroadcastTxCommitfromsignAndBroadcastTxCommitContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description