Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gnobro, a terminal-based realm browser #2608

Merged
merged 70 commits into from
Aug 23, 2024

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Jul 21, 2024

This PR introduces gnobro, a terminal-based browser to explore realms and enhance the user development experience on gnodev.

out

TODO

  • minimal documentation
  • Add tests somehow
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
@gfanton gfanton self-assigned this Jul 21, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jul 21, 2024
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.20%. Comparing base (e60e4ca) to head (3ad927c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   60.21%   60.20%   -0.01%     
==========================================
  Files         562      562              
  Lines       75026    75007      -19     
==========================================
- Hits        45177    45160      -17     
  Misses      26475    26475              
+ Partials     3374     3372       -2     
Flag Coverage Δ
contribs/gnodev 61.40% <100.00%> (+0.81%) ⬆️
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 64.46% <100.00%> (-0.15%) ⬇️
gnovm 64.33% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (-0.36%) ⬇️
tm2 61.97% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@deelawn deelawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 🥇 You've inspired me to use charm in a future project. I left a few comments and questions but nothing too serious.

contribs/gnodev/cmd/gnobro/main.go Outdated Show resolved Hide resolved
contribs/gnodev/cmd/gnobro/main.go Show resolved Hide resolved
contribs/gnodev/cmd/gnobro/banner.go Outdated Show resolved Hide resolved
contribs/gnodev/cmd/gnobro/main.go Outdated Show resolved Hide resolved
contribs/gnodev/pkg/browser/client_dev.go Outdated Show resolved Hide resolved
contribs/gnodev/pkg/browser/client_dev.go Show resolved Hide resolved
contribs/gnodev/pkg/browser/model.go Show resolved Hide resolved
@gfanton gfanton merged commit b7dbed9 into gnolang:master Aug 23, 2024
120 checks passed
@gfanton gfanton deleted the feat/contribs-gnobro branch August 23, 2024 08:33
@kroppacat
Copy link

Hello Gnomes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants