-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlibs/std)!: remove std.CurrentRealmPath
#2087
Merged
Merged
+31
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhpn99
requested review from
jaekwon,
deelawn,
thehowl,
mvertes,
a team and
moul
as code owners
May 13, 2024 15:05
github-actions
bot
added
🧾 package/realm
Tag used for new Realms or Packages.
📦 🤖 gnovm
Issues or PRs gnovm related
labels
May 13, 2024
this PR relates to #2045 |
linhpn99
changed the title
deprecate & remove std.CurrentRealmPath()
chore(gnovm): deprecate & remove std.CurrentRealmPath()
May 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2087 +/- ##
=======================================
Coverage 49.01% 49.02%
=======================================
Files 576 576
Lines 77604 77578 -26
=======================================
- Hits 38035 38029 -6
+ Misses 36486 36467 -19
+ Partials 3083 3082 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@thehowl hope u give a review |
thehowl
reviewed
May 15, 2024
zivkovicmilos
added
the
breaking change
Functionality that contains breaking changes
label
May 15, 2024
@thehowl does my PR good enough to approve ? |
thehowl
approved these changes
May 23, 2024
LGTM, @gfanton for second review |
gfanton
approved these changes
May 23, 2024
thehowl
approved these changes
May 23, 2024
thehowl
changed the title
chore(gnovm): deprecate & remove std.CurrentRealmPath()
feat(stdlibs/std)!: remove May 23, 2024
std.CurrentRealmPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Functionality that contains breaking changes
📦 🤖 gnovm
Issues or PRs gnovm related
🧾 package/realm
Tag used for new Realms or Packages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description