Merge pull request #19 from ohmybrew/issue-18

Issue 18 Investigation
gnikyt · Mar 19, 2018 · f996028 · f996028 · ncpope · Mar 20, 2018
2 parents f6604c5 + 37672d2
commit f996028
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/ShopifyApp/Middleware/AuthShop.php b/src/ShopifyApp/Middleware/AuthShop.php
@@ -30,7 +30,7 @@ public function handle(Request $request, Closure $next)
             // Either no shop session or shops do not match
             session()->forget('shopify_domain');
 
-            return redirect()->route('authenticate')->with('shop', $shopParam);
+            return redirect()->route('authenticate', ['shop' => $shopParam]);
         }
 
         // Shop is OK, move on...

diff --git a/src/ShopifyApp/Traits/AuthControllerTrait.php b/src/ShopifyApp/Traits/AuthControllerTrait.php
@@ -26,15 +26,14 @@ public function index()
     public function authenticate()
     {
         // Grab the shop domain (uses session if redirected from middleware)
-        $shopDomain = request('shop') ?: session('shop');
+        $shopDomain = request('shop');
         if (!$shopDomain) {
             // Back to login, no shop
             return redirect()->route('login');
         }
 
         // Save shop domain to session
         session(['shopify_domain' => ShopifyApp::sanitizeShopDomain($shopDomain)]);
-        session()->forget('shop');
 
         if (!request('code')) {
             // Handle a request without a code

diff --git a/tests/Middleware/AuthShopMiddlewareTest.php b/tests/Middleware/AuthShopMiddlewareTest.php
@@ -47,7 +47,7 @@ public function testShopsWhichDoNotMatchShouldKillSessionAndDirectToReAuthentica
         });
 
         $this->assertFalse($called);
-        $this->assertEquals('example-different-shop.myshopify.com', session('shop'));
+        $this->assertEquals('example-different-shop.myshopify.com', request('shop'));
     }
 
     public function testHeadersForEsdkShouldBeAdjusted()