Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added simpson's 1/3 rule #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added simpson's 1/3 rule #27

wants to merge 4 commits into from

Conversation

varchasa
Copy link

@varchasa varchasa commented Oct 7, 2020

Implemented simpson's 1/3 rule using python and numpy. For test cases you can choose any of the options mentioned in the program.

@gmuraru
Copy link
Owner

gmuraru commented Oct 7, 2020

You should implement a function for it and not waiting for user input

@varchasa
Copy link
Author

varchasa commented Oct 8, 2020

Okay I will do it

@varchasa
Copy link
Author

varchasa commented Oct 8, 2020

Hey, I have done the changes. Kindly check out.

@gmuraru
Copy link
Owner

gmuraru commented Oct 8, 2020

Hey!
all the logic should be encapsulated in a function like:

def simpsons_13rule(upper_bound, lower_bound, number_points, function)

@varchasa
Copy link
Author

varchasa commented Oct 8, 2020

Hey, check the changes. I implement the numpy function as another user defined function.

@varchasa
Copy link
Author

varchasa commented Oct 8, 2020

I have built the program using one function only. Also, added some test cases. Do check it.

@varchasa
Copy link
Author

varchasa commented Oct 9, 2020

Sir I am not getting it. I have gone through the src and test folders. But I am unable to add test cases.

@gmuraru
Copy link
Owner

gmuraru commented Oct 9, 2020

Could you explain to me what is the problem?
What you should do:

  1. In the Approximations folder add a new folder simson's rule
  2. Create 2 folders there src and test
  3. Add you file in the src folder
  4. Add some tests in the test folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants