CSUB-1382: Unblock runtime upgrade testing for mainnet #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example of successfull Runtime Upgrade execution against Mainnet: https://github.com/gluwa/creditcoin3/actions/runs/11952245910 |
originally this CI config was a copy from Creditcoin 2 where the node binary accepts both --chain main and --chain mainnet. However Creditcoin3 recognizes only the value "mainnet"!
atodorov
force-pushed
the
testing/CSUB-1382-unblock-runtime-upgrade-testing-for-mainnet
branch
from
6ba5645
to
bd1f8ed
Compare
atodorov
requested review from
DylanVerstraete,
BradleyOlson64,
beqaabu and
rustlang-dev
|
For full LLVM coverage report click here! |
beqaabu
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
lgtm
note: fyi the runtime wasnt actually upgraded because the version wasn't bumped
https://github.com/gluwa/creditcoin3/actions/runs/11952245910/job/33318862352
atodorov
deleted the
testing/CSUB-1382-unblock-runtime-upgrade-testing-for-mainnet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Practical tips for PR review & merge: