-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update tx payment pallet config #525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustlang-dev
requested review from
atodorov,
dave1374,
DylanVerstraete,
BradleyOlson64 and
beqaabu
November 15, 2024 15:56
https://github.com/gluwa/creditcoin3/actions/runs/11859392335/job/33052219116?pr=525 - false positive - detecting MILLISECS_PER_BLOCK b/c it is in the git diff context. Can be ignored. |
https://github.com/gluwa/creditcoin3/actions/runs/11859392339/job/33052220888?pr=525 - secretleaks issue intorduced in #483, can be ingored here. |
For full LLVM coverage report click here! |
DylanVerstraete
previously approved these changes
Nov 15, 2024
BradleyOlson64
previously approved these changes
Nov 15, 2024
beqaabu
previously approved these changes
Nov 15, 2024
rustlang-dev
dismissed stale reviews from beqaabu, BradleyOlson64, and DylanVerstraete
via
November 15, 2024 16:37
e5e094c
beqaabu
previously approved these changes
Nov 15, 2024
rustlang-dev
requested review from
beqaabu,
DylanVerstraete and
BradleyOlson64
November 15, 2024 19:12
DylanVerstraete
approved these changes
Nov 15, 2024
BradleyOlson64
approved these changes
Nov 15, 2024
beqaabu
pushed a commit
that referenced
this pull request
Nov 18, 2024
* update tx payment pallet LengthToFee TransactionByteFee * fix clippy * cargo toml to v 39
DylanVerstraete
pushed a commit
that referenced
this pull request
Nov 18, 2024
* update tx payment pallet LengthToFee TransactionByteFee * fix clippy * cargo toml to v 39 Co-authored-by: rust dev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
update tx payment pallet config
Practical tips for PR review & merge: