CSUB-1231: Use --profile=production for all builds & CI jobs

[atodorov]

Description of proposed changes

---

Practical tips for PR review & merge:

• All GitHub Actions report PASS
• Newly added code/functions have unit tests
  • Coverage tools report all newly added lines as covered
  • The positive scenario is exercised
  • Negative scenarios are exercised, e.g. assert on all possible errors
  • Assert on events triggered if applicable
  • Assert on changes made to storage if applicable
• Modified behavior/functions - try to make sure above test items are covered
• Integration tests are added if applicable/needed

[atodorov]

@BradleyOlson64 as-is this change is not being exercised when a PR is created because it gets triggered by a git tag. IMO if https://github.com/gluwa/creditcoin3/actions/runs/10303559931/job/28519918476?pr=437 is failing this one will fail as well.

[github-actions]

For full LLVM coverage report click here!

[BradleyOlson64]

These changes look right.

Just to make sure, we're fine with CI runs taking 1.5x longer than before right?

Production builds take quite a bit longer than release builds so I was envisioning only using production for final image builds.

[atodorov]

These changes look right.

Just to make sure, we're fine with CI runs taking 1.5x longer than before right?

Can you be more precise? Which jobs are taking 1.5x because I'm not able to spot anything obvious ?

Production builds take quite a bit longer than release builds so I was envisioning only using production for final image builds.

Multiple integration tests with the --profile=production build are currently failing, https://github.com/gluwa/creditcoin3/actions/runs/10305191630/job/28527968917?pr=437 and IMO the only way to have some confidence in these builds is to actually exercise them before we ship. Otherwise we end up in the situation where we test one target, however we ship a different target which is completely untested - not good IMO.

Correction: the failures were due to ommissions to update some of the test scripts, not cause by the SUT itself. However the second point of above statement still holds true.

[atodorov]

Runtime upgrade testing -> https://github.com/gluwa/creditcoin3/actions/runs/10317027713/job/28566440763 seems to me to be working fine.

The rest of the testing is in this PR which also appears to be looking good. Will port to creditcoin3-next and close this one shortly after!