-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility and tests against Numpy 2.0.0rc1 #2471
Conversation
1019a42
to
c8b9f15
Compare
577fc7e
to
9815e28
Compare
For pandas and matplotlib, I did a hack in my packages to let them downgrade numpy first but then force numpy dev reinstall right before test start running and ignore the pip warning. It's not pretty but easier than --no-deps . shapely is indeed more troublesome. They never replied to my request. |
6c542a8
to
3def015
Compare
18866af
to
4e8600a
Compare
Running now with numpy 2.0.0rc1, astropy 6.1.0rc1 and scipy 1.13.0; fast-histogram still needs its own build (see astrofrog/fast-histogram#86 (comment)); have not checked for released versions of other dependencies yet. |
@astrofrog I have used a simplified version of the Scipy fix, since we should not need to worry about earlier numpy 2.0.0dev versions that did not support Shapely has a new release built on shapely/shapely#2033 Before merging we should decide which Don't have a way to debug the pandas-related Windows failures. |
@dhomeier - are you sure it's still not working with casa-formats-io v0.3.0? There is a devdeps job there that shows that it works fine with numpy 2.0.0rc1 at runtime: https://github.com/radio-astro-tools/casa-formats-io/actions/runs/8720397149/job/23921906624 |
tox.ini
Outdated
dev: astropy>=0.0.dev0 | ||
dev: pandas>=0.0.dev0 | ||
dev: git+https://github.com/radio-astro-tools/casa-formats-io.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check that v0.3.0 works now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to pip install on macOS several times now, always getting a numpy 1.26 version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a caching problem just as with shapely; seems to be running here as well, but then the installed versions of other deps don't make any sense with what is in tox.ini
now. Rebasing to try to get this sorted...
08f7e3c
to
c17fef5
Compare
… contourpy+pandas+shapely unpinned
# for as long all test deps need to be manually pulled in above as well! | ||
install_command = | ||
!dev: python -I -m pip install | ||
dev: python -I -m pip install -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this help?
dev: python -I -m pip install -v | |
dev: python -I -m pip install -v --pre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removed this as we should no longer need any git installs; the >=0.0.dev0
versions apparently install without it 🤪
@dhomeier is this ok to merge? (If so feel free to!) |
Yes, think so – I made on run with pandas dev to check the Windows failures (still persisted), but don't think we need that in general; thanks! |
Description
Installing numpy dev in CI is currently blocked by various upstream packages pinned to
numpy < 2.0
; adding those to the developer versions.This would update both
dev
jobs tonumpy>=0.0.dev0
; restrict to a new envnpdev
instead?pandas has no compatible wheel and a hard dependency on.numpy < 2.0
contourpy has no compatible wheel and a hard dependency on.numpy < 2.0
shapely has no compatible wheel for(Wheel that is compatible with numpy 2.0.dev ? shapely/shapely#1949), build depends on libgeos.numpy < 2.0
fast-histogram has no compatible wheel.and a pinned dependency on.numpy < 2.0
Only workaround for the pins seems to be to install with
--no-deps
(pandas-dev/pandas#55488) which in turn requires every single test dependency to be pulled in explicitly; if anyone has an idea how to run a first pass without--no-deps
an then a secondpip install
to override the numpy pin, that could be simplified a bit.Building shapely seems to require compiling its own
libgeos
installation per itsinstall script; unless I find a way to get an apt install for that, this is a showstopper for now.
(It seems to be available, but would require pointing the CI to fetch from an alternative repo).