Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save WWT interactive figure #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsub1
Copy link

@jsub1 jsub1 commented Jun 28, 2019

Addresses #46 by using the pywwt interactive figure work (WorldWideTelescope/pywwt#215). This PR adds the option to save the current view to a zip file with an HTML page and supporting script and data files.

@astrofrog
Copy link
Member

@jsub1 - sorry this never got merged! Can you rebase and resolve the conflicts?

@astrofrog
Copy link
Member

@Carifio24 - could you see if this can be rebased/wrapped up?

@pkgw
Copy link
Contributor

pkgw commented May 19, 2022

Note that the save_as_html_bundle infrastructure is still in pywwt for now, but it's based on the much older JS/HTML implementation from before we got everything tidied up. I think the code should still work, but it might have some issues, and it would definitely be nice to pull the pywwt implementation up to use the Research App framework.

@Carifio24
Copy link
Member

I played around with this a bit, and while the basic setup save_as_html_bundle still works, it can't export a view that has any layers because the time_decay layer attribute (added after this functionality was implemented) is currently not JSON serializable.

Adding the serialization support should be straightforward, and then this would work until we get around to modifying it to use the research app.

@Carifio24
Copy link
Member

@astrofrog With WorldWideTelescope/pywwt#332 and WorldWideTelescope/pywwt#345 this should be working now (it will work with only 332, but won't properly export point sizes). Maybe we want to add some sort of pywwt-version-based enabling? I don't have the proper permissions to rebase this since it's not my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants