New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable raising deprecation warnings #361

Open

astrofrog wants to merge 1 commit into glue-viz:main from astrofrog:deprecations

Member

astrofrog commented Jun 23, 2023

Just disable this for visual tests due to widgetti/solara#171


Re-enable raising deprecation warnings in default case and disable ju…

39ffc2b

…st for visual tests due to deprecation warnings in solara

astrofrog force-pushed the deprecations branch from bd60a31 to 39ffc2b Compare

August 3, 2023 13:25

Contributor

dhomeier commented Aug 16, 2023

I think this will need the following updates to ignores:

-    ignore:Keyword `trait:DeprecationWarning:pythreejs.*:
+    ignore:Keyword `trait` is deprecated in traitlets.*:DeprecationWarning:bqplot.*:
+    ignore:zmq.eventloop.ioloop is deprecated in pyzmq.*:DeprecationWarning:jupyter_client.*:
+    ignore:`BqplotScatterLayerState` is deprecated and will be removed in a future version.*:DeprecationWarning:glue_jupyter.bqplot.scatter.*:

(though maybe we should better add a pytest.warns context to our own glue_jupyter.bqplot.scatter tests).

dhomeier added testing no-changelog-entry-needed labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment