Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure IllustrationManager::render can't be abused to read any file #18050

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make sure IllustrationManager::render can't be abused to read any file #18050

wants to merge 1 commit into from

Conversation

AdrienClairembault
Copy link
Contributor

@AdrienClairembault AdrienClairembault commented Oct 11, 2024 •
edited
Loading

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

  • Make sure the IllustrationManager::render method can't be abused to read any file.
  • Validate that the TileManager default tiles use valid illustration in our tests
  • Remove default icon fallback in IllustrationManager

@AdrienClairembault AdrienClairembault self-assigned this Oct 11, 2024
@AdrienClairembault AdrienClairembault changed the title Increase IllustrationSafety and improve tests Make sure IllustrationManager::render can't be abused to read any file Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AdrienClairembault AdrienClairembault

Labels
Forms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AdrienClairembault