Start Removing Search SQL quirks #14002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
reviewed
Jun 7, 2023
cconard96
force-pushed
the
feature/remove_search_hacks
branch
from
639691e
to
84dce1d
Compare
cconard96
force-pushed
the
feature/remove_search_hacks
branch
from
6550df7
to
5b50583
Compare
cconard96
force-pushed
the
feature/remove_search_hacks
branch
from
33367ab
to
6232d16
Compare
cconard96
force-pushed
the
feature/remove_search_hacks
branch
from
6232d16
to
486bc9a
Compare
|
Restarting work on this to simplify/de-duplicate permission checks done by the web Search engine and the one in the HLAPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on all previous pending SQL/Search PRs. Starts at 639691e.
Removes Search Engine hacks/quirks for specific itemtypes from
SQLProviderand puts them into the related itemtype classes.This should also allow for the searching of some virtual search options.