fix: Fix TacticalRMM Remote_Mgmt agent version discovery

glpi-project · Jul 9, 2024 · 661f114 · 661f114
1 parent e2207b7
commit 661f114
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/GLPI/Agent/Task/Inventory/Generic/Remote_Mgmt/TacticalRMM.pm b/lib/GLPI/Agent/Task/Inventory/Generic/Remote_Mgmt/TacticalRMM.pm
@@ -96,11 +96,13 @@ sub _getVersion {
         :
         canRun("rmmagent") ? "rmmagent --version" : "/usr/local/bin/rmmagent --version";
 
-    return getFirstMatch(
+    # On windows, the command seems to output a BOM on the first line
+    my $line = getSanitizedString(getFirstLine(
         command => $command,
-        pattern => qr/^Tactical RMM Agent:\s+(\S+)/i,
         %params
-    );
+    ));
+
+    return $line =~ /Tactical RMM Agent:\s+([0-9.]+)/i;
 }
 
 1;