Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Attempt creation of symlink on Windows and handle exceptions. #958

Merged
merged 9 commits into from
Nov 16, 2023

Conversation

slowglow
Copy link
Contributor

@slowglow slowglow commented Nov 15, 2023

Description

If symlinks are not enabled on Windows, issue a guiding message.

Motivation and Context

See #430 (comment)

Checklist:

If symlinks are not enabled on Windows, issue a guiding message.
@slowglow slowglow requested review from a team as code owners November 15, 2023 03:50
@slowglow slowglow requested review from mikemhenry and shihkual and removed request for a team November 15, 2023 03:50
Change of wording of the message: 
- removed mention of Python <3.8, which is not supported.
- removed reference to external sites, which may go down in the future.
signac/linked_view.py Outdated Show resolved Hide resolved
signac/linked_view.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (249fcc9) 85.68% compared to head (f1b4e24) 85.63%.

❗ Current head f1b4e24 differs from pull request most recent head 4f3c12b. Consider uploading reports for the commit 4f3c12b to get more accurate results

Files Patch % Lines
signac/linked_view.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
- Coverage   85.68%   85.63%   -0.05%     
==========================================
  Files          20       20              
  Lines        3457     3461       +4     
  Branches      758      758              
==========================================
+ Hits         2962     2964       +2     
- Misses        335      338       +3     
+ Partials      160      159       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied some changes to the tests. I verified locally that these tests are skipped on Windows when Developer Mode is disabled, and they pass on Windows when Developer Mode is enabled. This looks good to me.

@b-butler @cbkerr @joaander if you have feedback, feel free to weigh in -- otherwise I think this is good to merge.

Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slowglow and @bdice! The change is reasonable to allow functionality previously not allowed and the unit tests are updated appropriately.

@bdice
Copy link
Member

bdice commented Nov 15, 2023

FYI, CI looks blocked (perhaps due to #957) because the expected checks are changing.

image

@joaander
Copy link
Member

FYI, CI looks blocked (perhaps due to #957) because the expected checks are changing.

I removed the 3.12 required checks for now. #957 appears to have some issues with pandas that may take some time to resolve.

Copy link
Member

@cbkerr cbkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bdice bdice merged commit 7884ebd into glotzerlab:main Nov 16, 2023
17 checks passed
@cbkerr cbkerr added this to the v2.2.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants