-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX]: Attempt creation of symlink on Windows and handle exceptions. #958
Conversation
If symlinks are not enabled on Windows, issue a guiding message.
Change of wording of the message: - removed mention of Python <3.8, which is not supported. - removed reference to external sites, which may go down in the future.
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
==========================================
- Coverage 85.68% 85.63% -0.05%
==========================================
Files 20 20
Lines 3457 3461 +4
Branches 758 758
==========================================
+ Hits 2962 2964 +2
- Misses 335 338 +3
+ Partials 160 159 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied some changes to the tests. I verified locally that these tests are skipped on Windows when Developer Mode is disabled, and they pass on Windows when Developer Mode is enabled. This looks good to me.
@b-butler @cbkerr @joaander if you have feedback, feel free to weigh in -- otherwise I think this is good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, CI looks blocked (perhaps due to #957) because the expected checks are changing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
If symlinks are not enabled on Windows, issue a guiding message.
Motivation and Context
See #430 (comment)
Checklist: