Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added drop down icon for menu items that have sub menu items #3138 #3171

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Vimalnegi03
Copy link
Contributor

@Vimalnegi03 Vimalnegi03 commented Dec 15, 2024

**Description-:**Added drop down icon for menu items that have sub menu items #3138
Screenshot_15-12-2024_19493_glific test
Screenshot_15-12-2024_194833_glific test

Copy link

github-actions bot commented Dec 15, 2024

@github-actions github-actions bot temporarily deployed to pull request December 15, 2024 17:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 15, 2024 17:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 15, 2024 18:01 Inactive
@Vimalnegi03 Vimalnegi03 self-assigned this Dec 15, 2024
Copy link

cypress bot commented Dec 15, 2024

Glific    Run #5470

Run Properties:  status check passed Passed #5470  •  git commit 83b604d3c9 ℹ️: Merge 8e55a788d98a5a32ebf93c3cfe5134a365476a09 into bfbb7cc5f204d2c34ae32c5df333...
Project Glific
Branch Review enhancement/dropdown_side_pannel
Run status status check passed Passed #5470
Run duration 25m 41s
Commit git commit 83b604d3c9 ℹ️: Merge 8e55a788d98a5a32ebf93c3cfe5134a365476a09 into bfbb7cc5f204d2c34ae32c5df333...
Committer Vimal Negi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request December 15, 2024 20:49 Inactive
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (bfbb7cc) to head (8e55a78).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3171      +/-   ##
==========================================
- Coverage   81.70%   81.68%   -0.03%     
==========================================
  Files         330      330              
  Lines       10494    10497       +3     
  Branches     2192     2195       +3     
==========================================
  Hits         8574     8574              
- Misses       1308     1310       +2     
- Partials      612      613       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vimalnegi03

Thank you.

Icons are not aligned correctly. It should not be dependent on the length of the menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants