-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added drop down icon for menu items that have sub menu items #3138 #3171
base: master
Are you sure you want to change the base?
Conversation
🚀 Deployed on https://deploy-preview-3171--glific-frontend.netlify.app |
Glific Run #5470
Run Properties:
|
Project |
Glific
|
Branch Review |
enhancement/dropdown_side_pannel
|
Run status |
Passed #5470
|
Run duration | 25m 41s |
Commit |
83b604d3c9 ℹ️: Merge 8e55a788d98a5a32ebf93c3cfe5134a365476a09 into bfbb7cc5f204d2c34ae32c5df333...
|
Committer | Vimal Negi |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
169
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3171 +/- ##
==========================================
- Coverage 81.70% 81.68% -0.03%
==========================================
Files 330 330
Lines 10494 10497 +3
Branches 2192 2195 +3
==========================================
Hits 8574 8574
- Misses 1308 1310 +2
- Partials 612 613 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Icons are not aligned correctly. It should not be dependent on the length of the menu.
**Description-:**Added drop down icon for menu items that have sub menu items #3138