Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whatsapp group fields ui #3168

Merged
merged 3 commits into from
Dec 15, 2024
Merged

whatsapp group fields ui #3168

merged 3 commits into from
Dec 15, 2024

Conversation

akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Dec 13, 2024

Fields ui for whatsapp groups

Copy link

github-actions bot commented Dec 13, 2024

@github-actions github-actions bot temporarily deployed to pull request December 13, 2024 04:14 Inactive
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.69%. Comparing base (3e5857e) to head (69ee39f).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../Contact/ContactDescription/ContactDescription.tsx 85.00% 0 Missing and 3 partials ⚠️
...tainers/WaGroups/GroupDetails.tsx/GroupDetails.tsx 78.57% 2 Missing and 1 partial ⚠️
src/components/floweditor/FlowEditor.helper.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3168   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files         329      329           
  Lines       10469    10491   +22     
  Branches     2184     2192    +8     
=======================================
+ Hits         8553     8571   +18     
- Misses       1306     1308    +2     
- Partials      610      612    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 linked an issue Dec 13, 2024 that may be closed by this pull request
3 tasks
@akanshaaa19 akanshaaa19 self-assigned this Dec 13, 2024
@akanshaaa19 akanshaaa19 requested a review from kurund December 13, 2024 04:22
Copy link

cypress bot commented Dec 13, 2024

Glific    Run #5461

Run Properties:  status check passed Passed #5461  •  git commit 01a8991eff ℹ️: Merge c2025391c719c84f3361f769247c2b53707a30ed into 3e5857e050f3300e13d812f37f1b...
Project Glific
Branch Review feature/wa_groups
Run status status check passed Passed #5461
Run duration 27m 07s
Commit git commit 01a8991eff ℹ️: Merge c2025391c719c84f3361f769247c2b53707a30ed into 3e5857e050f3300e13d812f37f1b...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

Added support for updating whatsapp group node
@github-actions github-actions bot temporarily deployed to pull request December 15, 2024 19:40 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@kurund kurund merged commit d0ae9c1 into master Dec 15, 2024
10 of 13 checks passed
@kurund kurund deleted the feature/wa_groups branch December 15, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group fields for whatsapp fields
2 participants